Disable lsan.test_asyncify_during_exit. NFC #14364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test allocates the asyncify stack during the exit handlers and
it's never freed.
Interestingly enough this leak was not caught prior to #14280.
I did some investigation and found that prior to #14280 this
chunk was bring detected a reachable via the conservative stack
scan here:
emscripten/system/lib/compiler-rt/lib/lsan/lsan_common_emscripten.cpp
Lines 141 to 153 in 98a8cbf
If I comment out this stack scan then this leak will be
detected even before #14280
Also, add
--profiling
to asan and lsan builds to makeerror reports more useful.
See #14360