Warn when we map unrecognized library files to -l flags.
#14746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
warn_on_library_mapping
branch
from
51a2f70 to
123375a
Compare
kripken
approved these changes
Jul 23, 2021
This is rather an odd feature and I think we should notify users if they are relying on it. Honestly I doubt many are. See #14689 for an example of how confusing it can be when it goes wrong. Also, make sure we strip off the full suffix in the case of `.so.1.2.3` suffixes.
sbc100
force-pushed
the
warn_on_library_mapping
branch
from
123375a to
3969a9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather an odd feature and I think we should notify users if they
are relying on it. Honestly I doubt many are.
See #14689 for an example of how confusing it can be when it goes wrong.
Also, make sure we strip off the full suffix in the case of
.so.1.2.3suffixes.