-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Support --preload-file in the shell environment and d8 #15337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/** | ||
* @license | ||
* Copyright 2021 The Emscripten Authors | ||
* SPDX-License-Identifier: MIT | ||
*/ | ||
|
||
// In d8 and other shells xhr might not exist. Polyfill it so that preload-file | ||
// works. | ||
// This is hackish and affects the global scope, but this file is only included | ||
// when using the shell environment, which is not on by default, and only takes | ||
// effect when XMLHttpRequest is not defined, which basically means when testing | ||
// in the shell locally. | ||
if (typeof XMLHttpRequest === 'undefined') { | ||
XMLHttpRequest = function() { | ||
return { | ||
open: function(mode, path, async) { | ||
this.mode = mode; | ||
this.path = path; | ||
this.async = async; | ||
}, | ||
send: function() { | ||
if (!this.async) { | ||
this.doSend(); | ||
} else { | ||
var that = this; | ||
setTimeout(function() { | ||
that.doSend(); | ||
if (that.onload) that.onload(); | ||
}, 0); | ||
} | ||
}, | ||
doSend: function() { | ||
if (this.responseType == 'arraybuffer') { | ||
this.response = read(this.path, 'binary'); | ||
} else { | ||
this.responseText = read(this.path); | ||
} | ||
this.status = 200; | ||
}, | ||
}; | ||
}; | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, how about an internal settings called
INCLUDE_XHR_POLYFILL
which can be set when the file packager is used? Then we can avoid this unless is needed?