emar: only use a response file if needed. NFC #15668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
emar_response_file
branch
from
63f700f to
8f1c9b6
Compare
All the other command runners in `tools/building.py` use this pattern already. `test_emar_response_file` was updated to explictly use a response file.
sbc100
force-pushed
the
emar_response_file
branch
from
8f1c9b6 to
822297c
Compare
kripken
approved these changes
Nov 30, 2021
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
All the other command runners in `tools/building.py` use this pattern already. `test_emar_response_file` was updated to explicitly use a response file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other command runners in
tools/building.pyuse thispattern already.
test_emar_response_filewas updated to explictly use aresponse file.