Handle memory exceptions errors in MEMFS #17232
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When memory allocation exceptions occur in MEMFS from a thread, it causes the thread to fail without recovery (see #16548 and #11496 for details). Instead we catch the exception at the source and replace it with an ERRNO exception, which is handled appropriately. This also works better for non-threaded code. Other exception values to consider: EDQUOT or ENOSPC.
tlively
reviewed
Jun 16, 2022
Comment on lines
+122
to
+123
| } | ||
| catch(e) { |
There was a problem hiding this comment.
Suggested change
| } | |
| catch(e) { | |
| } catch(e) { |
sbc100
approved these changes
Jun 18, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When memory allocation exceptions occur in MEMFS from a thread, it causes the thread to fail without recovery (see #16548 and #11496 for details). Instead we catch the exception at the source and replace it with an ERRNO exception, which is handled appropriately. This also works better for non-threaded code. Other exception values to consider: EDQUOT or ENOSPC.