[Wasm64] Fix creation of 64-bit memories from JS #20111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also means that once this lands, the memory64 feature will only work with Chrome builds that have the new JS API support, right? |
No.. extra attributes seem to just get ignored so it should have no effect. Even it if did it would only effect those who use |
dschuff
reviewed
Aug 23, 2023
|
So IIUC the thing that this actually makes work is the use cases for |
dschuff
approved these changes
Aug 23, 2023
This enables quite a few tests that were previously disabled. The extra check for `navigator.userAgent` is because node added support for the navigator object: nodejs/node#47769. This change is also part of #19959, which could land instead.
sbc100
force-pushed
the
wasm64_4gb_external_memory
branch
from
020b0f4 to
5190960
Compare
|
Sure, I'll need to update that one anyway because some tests fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables quite a few tests that were previously disabled.
The extra check for
navigator.userAgentis because node added support for the navigator object: nodejs/node#47769.This change is also part of #19959, which could land instead.