Revert "Prefer calloc over of malloc+zeroMemory. NFC"
#22568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6619b4a.
brendandahl
approved these changes
Sep 13, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 19, 2024
…core#22568) This reverts commit 50e0b07.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
…core#22568) This reverts commit 50e0b07.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #22460
It's causing ASan/LSan failures:
https://ci.chromium.org/ui/p/emscripten-releases/builders/ci/linux-test-suites/b8737231127543572609/overview
I'm going to revert rather than fixing forward because I'm preparing a release.