[mimalloc] Error on mimalloc + ASan #23314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jan 6, 2025
tools/system_libs.py
Outdated
| @@ -2369,6 +2369,9 @@ def add_sanitizer_libs(): | |||
| add_library('libc') | |||
| if settings.MALLOC == 'mimalloc': | |||
| add_library('libmimalloc') | |||
| if settings.USE_ASAN: | |||
| # See https://github.com/emscripten-core/emscripten/issues/23288#issuecomment-2571648258 | |||
| shared.exit_with_error('mimalloc should not be used with asan') | |||
There was a problem hiding this comment.
mimalloc is not compatible with with asan?
Or "not currently" maybe?
There was a problem hiding this comment.
It sounded from the mimalloc people's responses there that this was by design (ASan uses its own allocator), IIUC.
There was a problem hiding this comment.
Sure, then 'mimalloc is not compatible with with asan' maybe?
sbc100
reviewed
Jan 6, 2025
| @@ -15209,6 +15209,11 @@ def test_wasm64_no_asan(self): | |||
| err = self.expect_fail([EMCC, test_file('hello_world.c'), '-sMEMORY64', '-fsanitize=address']) | |||
| self.assertContained('error: MEMORY64 does not yet work with ASAN', err) | |||
|
|
|||
| def test_mimalloc_no_asan(self): | |||
There was a problem hiding this comment.
Are there other mimalloc tests that this can be grouped with?
There was a problem hiding this comment.
I grouped this with the other asan test right above, which it is parallel to?
mighty1231
reviewed
Jan 7, 2025
test/test_other.py
Outdated
| def test_mimalloc_no_asan(self): | ||
| # See https://github.com/emscripten-core/emscripten/issues/23288#issuecomment-2571648258 | ||
| err = self.expect_fail([EMCC, test_file('hello_world.c'), '-sMALLOC=mimalloc', '-fsanitize=address']) | ||
| self.assertContained('error: mimalloc is not compatible with with -fsanitize=address', err) |
There was a problem hiding this comment.
How about this?
Suggested change
| self.assertContained('error: mimalloc is not compatible with with -fsanitize=address', err) | |
| self.assertContained('error: mimalloc is not compatible with -fsanitize=address', err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mimalloc is not meant to be used with ASan in general, see
#23288 (comment)
Fixes #23288