Make more use of optional chaining. NFC #23521
Merged
+31
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
optional_chainging
branch
from
a5e7da8 to
d00ce86
Compare
|
Reverted the non-NFC part |
dschuff
approved these changes
Jan 29, 2025
I found all these sites using: ``` $ git grep -n "if (\(.*\) && \1\>.*)" src/ ```
sbc100
force-pushed
the
optional_chainging
branch
from
d00ce86 to
3e72205
Compare
kripken
reviewed
Jan 29, 2025
| @@ -1184,7 +1184,7 @@ for (/**@suppress{duplicate}*/var i = 0; i <= {{{ GL_POOL_TEMP_BUFFERS_SIZE }}}; | |||
| } | |||
| // Make sure the canvas object no longer refers to the context object so | |||
| // there are no GC surprises. | |||
| if (GL.contexts[contextHandle] && GL.contexts[contextHandle].GLctx.canvas) { | |||
| if (GL.contexts[contextHandle]?.GLctx?.canvas) { | |||
There was a problem hiding this comment.
The second ? was not needed before so I assume it isn't after either?
There was a problem hiding this comment.
Good point, I'll try reverting that.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 29, 2025
sbc100
added a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found all these sites using: