-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[file_packager.py] Add --export-es6 to file_packager.py #24737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c4a662f
to
deac6ec
Compare
@sbc100 could you please take a look ? |
Can you explain a little more in the PR description exactly what |
I have added some use case description. As described in the related issue we are just trying to make the dynamic loading of large necessary dependencies inside web workers run from react application. Together with XHR lazy loading this seems to be only valid solution to our problem that might solve our problem. |
1b74c3e
to
05f9693
Compare
@sbc100 what do you think about it now? |
47dcb43
to
e2b3fc9
Compare
a83bbfe
to
58e06be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we still need a test for this.
And might be worth adding to the changelog.
Otherwise lgtm.
38f054e
to
0a72d80
Compare
I have added two simple tests - from what I have seen |
1e7790c
to
149e8b3
Compare
b011fb3
to
fb98269
Compare
e59ffa9
to
6f10cbb
Compare
daa7616
to
fd1ff56
Compare
c08fbb5
to
ad3b54c
Compare
I have added modularize option flag to
file_packager.py
script, like in main js generator - related to issue#24504I think it will be helpful since in modern world of react it is inconvinent to add generated files as
<script/>
tags.This pull request introduces a new
--export-es6
option to thefile_packager.py
tool, enabling the generation of modularized JavaScript output. It enables to import generated JS loading stub into ES6 environment. The main module which will take effect of script execution is now passed as script argument.Use scenario:
closes: #24504