-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[WIP] Add a windows launcher program to replace the current .bat
files
#24858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8974850
to
6c9f005
Compare
This is still just an experiment but eventually I hope to remove the `.bat` files in favor of this executable. There are several reasons to want to do this: 1. Batch files are notoriously painful to work with and mis-understood. 2. Should be faster (no need to launch cmd.exe). 3. Works around several known issues with .bat files including one that is known unsolvable one (see emcc.bat for more details)
.bat
files.bat
files
I don't know much about windows, but would we need to build this as part of the emsdk, ship it, etc.? How important are the issues solved by this? |
I think since its just a tiny |
Isn't there windows-on-arm, so a single binary wouldn't work? |
True! Although I'm not sure anyone is using that yet. We certainly don't yet provide emsdk binaries for windows/arm64. |
I haven't reviewed the code yet but I think this idea is generally good We did something similar for the NaCl compiler (for a different reason, but a similar technique). I think I have a mild preference for building it with emsdk rather than checking it in, but I could be convinced. |
} | ||
|
||
int main() { | ||
char exePath[MAX_PATH]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work with non-ascii directory/path names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a whole world of TCHAR
pain and Win32 file API coming someone's way...
FWIW PowerShell scripts I added a while back should also already solve this issue, and they're chosen by default on Windows when users type I don't mind the |
Windows have long had system similar to macOS Rosetta, it's just that Windows on ARM has only picked up in popularity recently with new laptops, but essentially any x64 Native ARM might be nice to have for wasm-binaries, but for something as simple as this invocation script perf shouldn't matter as much. |
Having to maintain the Sadly I don't think the |
Perhaps worth looking at py2exe than rolling something own? |
I have looked at things like that over the years but the complexity always scared me off. It would also be little sad to loose the "edit-in-place" abilities of the plain-old-python files. |
This is still just an experiment but eventually I hope to remove the
.bat
files in favor of this executable.There are several reasons to want to do this: