Crash fix for "for .. in + third party framework" bug #5036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this needed? What JS engine doesn't support for..in loops yet? |
|
Well, a lot of frameworks change Array.prototype (mootools, for instance) adding their custom functions there that are enumerable, unfortunately. So for..in will enumerate through that functions as well. Take a look at the modified test. With for..in this test would fail. |
|
Thanks! Was this enough to get the code running with mootools? Or are there other such locations? |
|
This was it. But looking at other 'for..in' appearances in emscripten js libraries I'd say it's theoretically possible to reproduce again. Do you know how to run all tests with Array.prototype modification as their prefix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced for..in only in library_gl but emscripten codebase is full of for..in's. Any idea how to handle this?