No EXPORT_ALL by default in main modules #7312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if your side modules want to call something from the main module, the main module must either export it (normally, on EXPORTED_FUNCTIONS), or you can manually enable EXPORT_ALL yourself. fixes #5586
|
Ah, so what's going on is that this removes the extra JS exports, but the JSBackend adds all functions to Exports internally, for a shared module. So we'd need to change fastcomp to modify that. Trying with that change, quite a lot of dynamic linking tests break. That might require a new option perhaps. |
|
See also #7319. We should do that stuff first before getting to this. |
|
Closing in favor of #7371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not automatically set
EXPORT_ALLforMAIN_MODULEs. This means that if your side modules want to call something from the main module, the main module must either export it (normally, on EXPORTED_FUNCTIONS), or you can manually enable EXPORT_ALL yourself.This is a breaking change, and documented in the changlog, but it's hard to show a useful error message when a problem occurs in practice. Let's discuss if this is worth doing or not. My guess is that there are few users of dynamic linking currently, and a few of them have requested this change, so it might be worth doing.
Partially fixes #5586. There are still many other exports, due to how function pointers work currently, I think.