Emit the dynCall functions in emulated function pointer mode to make … #7656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invokes with non-legal signatures work. Fixes emscripten-core#7399.
kripken
reviewed
Dec 17, 2018
| ret = ('return ' if sig[0] != 'v' else '') + shared.JS.make_coercion('FUNCTION_TABLE_%s[index&%s](%s)' % (sig, sig_mask, coerced_args), sig[0]) | ||
| if not shared.Settings.EMULATED_FUNCTION_POINTERS: | ||
| function_tables_impls.append(''' | ||
| if shared.Settings.EMULATED_FUNCTION_POINTERS: |
There was a problem hiding this comment.
I think this part of the patch could be simplified by setting sig to X if EMULATED_FUNCTION_POINTERS? That would avoid duplicated code in the if-else here (the return handling, the make_coercion call, etc.
Possibly we need a notion of an effective_sig if just changing the sig itself here or higher up does not make sense.
|
No longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…invokes with non-legal signatures work.
Fixes #7399.