Skip to content

Support for embedded .emscripten config #9547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Support for embedded .emscripten config #9547

merged 2 commits into from
Oct 9, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 30, 2019

emsdk has always had partial support for this. With this change all
emscripten users can take advantage of embedded config. This allows
different emscripten installations to have different configuration files
since they don't need to share a single config file in the user's home
directory.

As a followup and plan to make this location the default when generating
a new sample config file.

See #9543

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a test (in sanity I assume?)

sbc100 added 2 commits October 8, 2019 10:45
emsdk has always had partial support for this.  With this change all
emscripten users can take advantage of embedded config.  This allows
different emscripten installations to have different configuration files
since they don't need to share a single config file in the user's home
directory.

As a followup and plan to make this location the default when generating
a new sample config file.

See #9543
@sbc100 sbc100 merged commit 8f2ee09 into incoming Oct 9, 2019
@sbc100 sbc100 deleted the embedded_config branch October 9, 2019 01:32
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
emsdk has always had partial support for this.  With this change all
emscripten users can take advantage of embedded config.  This allows
different emscripten installations to have different configuration files
since they don't need to share a single config file in the user's home
directory.

As a followup and plan to make this location the default when generating
a new sample config file.

See emscripten-core#9543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants