Allow switching between overrides #1588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if one used e.g. command
then the overridden installation would create a git clone from
juj/emscripten
, and that clone would be located under the default remote nameorigin
.This would prevent being able to switch between overrides on subsequent
emsdk install
commands. I.e. it would then not be possible to later do a defaultcommand without an override, since the remote name
origin
would point tojuj/emscripten
instead ofemscripten-core/emscripten
.This PR changes the naming scheme of
git clone
s when--override-repository
is used, to name the clones with remote names from the override, so in the above case, the clone would appear under remote namejuj
and notorigin
.This enables flipping between multiple
emsdk install
commands in the same checkout, without needing to nuke the installed directory in between.This enables me to run experiments like github.com/emscripten-core/emscripten/pull/25025 locally on my CI, without needing to merge them upstream to become available.