Skip to content

Conversation

juj
Copy link
Collaborator

@juj juj commented Aug 23, 2025

Previously, if one used e.g. command

emsdk install --override-repository emscripten-main-64bit@https://github.com/juj/emscripten/tree/my_own_emscripten_branch emscripten-main-64bit

then the overridden installation would create a git clone from juj/emscripten, and that clone would be located under the default remote name origin.

This would prevent being able to switch between overrides on subsequent emsdk install commands. I.e. it would then not be possible to later do a default

emsdk install emscripten-main-64bit

command without an override, since the remote name origin would point to juj/emscripten instead of emscripten-core/emscripten.

This PR changes the naming scheme of git clones when --override-repository is used, to name the clones with remote names from the override, so in the above case, the clone would appear under remote name juj and not origin.

This enables flipping between multiple emsdk install commands in the same checkout, without needing to nuke the installed directory in between.

This enables me to run experiments like github.com/emscripten-core/emscripten/pull/25025 locally on my CI, without needing to merge them upstream to become available.

juj added 3 commits August 23, 2025 12:04
…rectives, without having to nuke the whole checkout tree from disk first.
@juj
Copy link
Collaborator Author

juj commented Aug 26, 2025

@sbc100 would you like to review this? Or I'll go ahead and land, probably nobody else uses --override-repository than Unity.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

Indeed I think you are likely the only user of this code.

@juj juj merged commit 0c45297 into main Aug 27, 2025
12 checks passed
@juj juj deleted the allow_switching_between_overrides branch August 27, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants