Add __config_site to libcxx #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains emscripten-specific settings so I think we should add this to the patch.
|
I don't think we should ever try to upstream this file so I'm not sure we want to submit it to our branch. Is there some reason you want to submit it here? |
|
Is the patch (and the library branches that include it) here meant to be the set of changes we someday want to upstream? If that's the case yeah we shouldn't include this. I thought this to be mostly for maintaining diff against the upstream for our own library-updating purpose. |
|
Yes, I think it s better to exclude this file from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file contains emscripten-specific settings so I think we should add this to the patch.