-
Notifications
You must be signed in to change notification settings - Fork 63
Fix Undefined Symbols while building llvm #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm, I thought the uploads failed but I see 19.1.2 here Am I missing something ? |
@anutosh491 the upload only fails client sided, but not on the server side! |
Ahh cool. Needed llvm19 for CppInterOp which you already merged. Thanks for the clarification :) |
Might just work out without the |
I realized the way i was passing the flags was hampering the symbols. The minor change in the last commit fixes most of it. It's only this one symbol that is undefined
Need to figure out how to fix this. If anyone has ideas, they are welcome ! |
Hey @DerThorsten I see you had added this through ec21b92 recipes/recipes/recipes_emscripten/llvm/build.sh Lines 7 to 8 in a4c4a03
Maybe we won't like to have
Just curious if we need to have no |
This is now ready. The above |
|
||
# Build step | ||
EMCC_CFLAGS='-sERROR_ON_UNDEFINED_SYMBOLS=0' emmake make -j1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review :)
Not sure why the upload to Quetz failed on all 3 previous updates on llvm
Need this for CppInterOp