ENYO-5217: Fix Spottable to prevent scroll on focus on webOS #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolved / Feature Added
Spottable components introduced odd scrolling behaviors in ScrollableNative due to built-in scroll on focus behaviors for the browser. On webOS, this can be prevented with the custom {{data-preventscrollonfocus}} attribute until the browser is updated to support the FocusOptions arg to
element.focus().Resolution
Added the
data-preventscrollonfocusto spottable but included it before the spread so that it can be overridden by applications. Given the scope of the change and that there is no clear way to describe this API in a cross-platform manner, I've left it off the prop types and public documentation. I'm not entirely opposed to including it but wanted to avoid confusion since it is unlikely to be used (e.g. using theoverflow: scrollon webOS).Additional Considerations
Links
whatwg/html#2787
Comments
Enact-DCO-1.0-Signed-off-by: Ryan Duffy ([email protected])