Request must inherit from HttpRequest

[sebpiq]

Request must become a subclass of Django's HttpRequest.
.DATA, .FILES, .auth and .method, previously available on views inheriting from RequestMixin will become request.DATA, request.FILES, request.method... Regular attributes on the request (eg. .META etc.) will still be available.
Also, .CONTENT probably needs to disappear and won't be provided by the new Request class.

[flashingpumpkin]

I'd love to see that.

Also, I'd love to see .CONTENT disappear because it's a property and a bit too magic-y. Validation shouldn't happen when looking at .CONTENT, but when calling .validate or some such.

[sebpiq]

I started working on that.

[sebpiq]

Need some advice here.

I can think of 3 approaches for doing that:

1. Dynamically attaching new properties (.DATA, ...) to the request.
   + no need to copy the whole request object
   - dynamically attaching properties to every request is maybe not the most efficient thing, and really hackish
   - a bit complicated
2. Generate subclass of the request class (done only once), then for each new request, create new instance of our own request class, and copy original request to this new instance.
   + seems the cleanest solution to me, since we are indeed using a subclass of the request
   - requires to copy the whole __dict__ for every request
3. Create a subclass of HttpRequest, which takes a request as only argument, and acts as a wrapper for it : it provides new properties on the wrapped request, and delegates the rest to the wrapped request.
   + no copy, no dynamically attaching properties, so probably the most performant
   - very hackish, and makes the subclassing of HttpRequest quite meaningless

I chose the 2. What are your opinions ?