-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
jQuery 1.9? #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll take a stab at "No, not really." The Browsable API works as is — and we don't have any test coverage to ensure updates to the JavaScript don't change that. (I guess it's not likely but a lot of people use the Browsable API so a breakage would be inconvenient to say the least.) I'll make a mental note to think about putting some basic tests in place — there's not a lot going on so it shouldn't require too much. In the meantime, is there any reason — other than keeping up to date — that you particularly want 1.9? |
This is related to #1085 — i.e. updating Twitter Bootstrap to v3. I'm kind of inclined towards the same response — i.e. Close pending a Pull Request. Looking again at |
What @carltongibson says, yup. (Feel free to go ahead and close tickets yourself @carltongibson if you believe it's appropriate - we can always reopen) I'll close this off - if someone wants to implement a PR updating to 1.9 that's fine and it'll be considered. Otherwise this isn't breaking anything as it currently is so there's no pressing need to update. I'd recommend any incoming PRs also include a couple of screenshots demonstrating any JS-related bits of behaviour still working. (Eg the tabs, syntax prettifiying and suchlike) |
Is there any reason why jquery 1.9 is not used?
The text was updated successfully, but these errors were encountered: