Skip to content

Bootstrap 3 templates for the browsable API #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hnarayanan opened this issue Sep 4, 2013 · 9 comments
Closed

Bootstrap 3 templates for the browsable API #1085

hnarayanan opened this issue Sep 4, 2013 · 9 comments

Comments

@hnarayanan
Copy link

I would like to migrate the templates in django-rest-framework to correspond to updates in Bootstrap 3. I did this for a personal site some months ago before Bootstrap 3 was released, and I am now in the process of updating those changes to 3.0.0. When ready, I would like to publish those changes so that it will be useful for others as well.

Is there some interest in this? I will submit a pull request if there is.

@tomchristie
Copy link
Member

Sounds good to me. Maybe worth including screenshots of before and after on this ticket, so we can see how different it looks.

@philipdouglas
Copy link
Contributor

I am interested in this. I had a go at doing it using just the replaceable blocks in the templates, but it wasn't possible.

Is there anything I can help with to make this happen?

@hnarayanan
Copy link
Author

I am still working on this sporadically, but would like some input because the scale of the changes. Which of the following do you guys believe is easier to review (and thus more likely to be accepted in the main source tree):

a. A clean rewrite of the templates starting with best practices from the Bootstrap 3 documentation, and styling it to look like the current templates.
b. A collection of incremental changes to the current templates to migrate them to Bootstrap 3, potentially leaving behind some legacy stuff that isn't relevant for the newer CSS.

@tomchristie
Copy link
Member

I'm really not in a position to comment as I've not looked into what would be needed to port the templates across.

I'm not massively fussed about 'best practise' so long as it all works nicely on different screen sizes and looks good.

On 30 Sep 2013, at 12:44, Harish Narayanan [email protected] wrote:

I am still working on this sporadically, but would like some input because the scale of the changes. Which of the following do you guys believe is easier to review (and thus more likely to be accepted in the main source tree):

a. A clean rewrite of the templates starting with best practices from the Bootstrap 3 documentation, and styling it to look like the current templates.
b. A collection of incremental changes to the current templates to migrate them to Bootstrap 3, potentially leaving behind some legacy stuff that isn't relevant for the newer CSS.


Reply to this email directly or view it on GitHub.

@hnarayanan
Copy link
Author

Thank you for the input. I will return to this starting with a rewrite rather than trying to migrate the current theme in small pieces.

@carltongibson
Copy link
Collaborator

I've migrated a couple of sites already. It wasn't too tough in the end.

Following the migration guide I found converting the class names to strip the -fluid — and making sure to update any custom CSS was about it.

I'd be inclined to just start with a fresh skeleton and then copy/paste the content blocks across (modifying as necessary).

@tomchristie
Copy link
Member

Given that there's nothing actually broken with the current templates, I'm going to close this off.
If someone proactively takes on a redesign based on Bootstrap 3 I'd be more than happy to consider a PR for it, but until that point I don't want to consider this as something that necessarily needs to be done.

@tomchristie
Copy link
Member

Reopening, now that we have an active PR addressing this in #1873.

tomchristie added a commit that referenced this issue Oct 31, 2014
@tomchristie
Copy link
Member

Now addressed in the upcoming version 3.0.

@tomchristie tomchristie removed this from the 2.4.4 Release milestone Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants