-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Remove pk_url_kwarg
, slug_url_kwarg
, slug_field
.
#1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@tomchristie I had been using: sites = serializers.HyperlinkedIdentityField(view_name='site-list',
lookup_field='slug', # Is this needed?
slug_url_kwarg='company_slug') to deal with urls that look like:
Now what do I do? |
@cancan101 It feels like drf-nested-routers will need an update to reflect this change. One should probably open an issue there about this change. |
I will cross post the issue, but the new set of arguments seems to me to be too limiting to get the old behavior. |
Or is my problem as simple as using lookup_url_kwarg instead of slug_url_kwarg ? |
I think you'll have to rename your field as |
@chibisov does this issue affect your nested router code too? |
These were placed on the deprecation path in 2.3, and replaced with
lookup_field
(and later,lookup_url_kwarg
).The will move from "pending deprecation" to "deprecated" in 2.4.
They need to be removed in 3.0.
The text was updated successfully, but these errors were encountered: