import coreapi failure since version 3.8.0

[gsvr]

Checklist

• I have verified that that issue exists against the master branch of Django REST framework.
• I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
• This is not a usage question. (Those should be directed to the discussion group instead.)
• This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
• I have reduced the issue to the simplest possible case.
• I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

Install django 2.0 with latest version of django-rest-framework via pip, and activate in settings.py
Try to open a shell and/or do:
from rest_framework.authtoken import views

Expected behavior

Should just load the views module.

Actual behavior

ModuleNotFoundError: No module named 'coreapi'

Suggested fix

It seems like the coreapi module should no longer be optional, but should be a dependency that installs with a pip install -

django-rest-framework/requirements/requirements-optionals.txt

Line 7 in 2709de1

coreapi==2.3.1

[DEKHTIARJonathan]

i have the same issue

[carltongibson]

Regression in 0d5a3a0. Ref #5676

[carltongibson]

Installing coreapi will work, but making it non-optional was not intended.

[carltongibson]

The import here should be from compat

django-rest-framework/rest_framework/authtoken/views.py

Lines 1 to 39 in bc35345

	import coreapi
	import coreschema
	from rest_framework import parsers, renderers
	from rest_framework.authtoken.models import Token
	from rest_framework.authtoken.serializers import AuthTokenSerializer
	from rest_framework.response import Response
	from rest_framework.schemas import ManualSchema
	from rest_framework.views import APIView
	class ObtainAuthToken(APIView):
	throttle_classes = ()
	permission_classes = ()
	parser_classes = (parsers.FormParser, parsers.MultiPartParser, parsers.JSONParser,)
	renderer_classes = (renderers.JSONRenderer,)
	serializer_class = AuthTokenSerializer
	schema = ManualSchema(
	fields=[
	coreapi.Field(
	name="username",
	required=True,
	location='form',
	schema=coreschema.String(
	title="Username",
	description="Valid username for authentication",
	),
	),
	coreapi.Field(
	name="password",
	required=True,
	location='form',
	schema=coreschema.String(
	title="Password",
	description="Valid password for authentication",
	),
	),
	],
	encoding="application/json",
	)

And the schema declaration (ln17) needs to be only if coreapi is not None:

I'd take a PR on this very happily! 🙂

[gsvr]

I'll supply a PR soon (in the next hour, hopefully).

[dz0]

can it be, that 3.7.7 is also affected?