Skip to content

There's no support for versioning when it comes to OpenAPI 3 spec generation #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 6 tasks
knivets opened this issue Aug 22, 2019 · 2 comments
Closed
5 of 6 tasks

Comments

@knivets
Copy link
Contributor

knivets commented Aug 22, 2019

Only URLPathVersioning works since it requires specifying the parameter manually in a url and inspector knows how to handle these. NamespaceVersioning is not relevant since you hardcode the version in the url so there are no parameters here.

I won't include examples for other schemes since it's lot of text to copy paste, but basically we should include appropriate parameters for QueryParameterVersioning, AcceptHeaderVersioning. Probably generate something in OpenAPI servers section for HostNameVersioning.

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

Expected behavior

Actual behavior

@carltongibson
Copy link
Collaborator

Yes. Super. This would be a good addition.

@tomchristie
Copy link
Member

Unlikely we'll be adding further OpenAPI functionality beyond what we've currently got in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants