Skip to content

Views are using a subclass or HttpRequest #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Views are using a subclass or HttpRequest #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ab0b72a
.DATA, .FILES, overloaded HTTP method, content type and content avail…
sebpiq Jan 22, 2012
8b72b7b
corrected request example
sebpiq Jan 24, 2012
714a90d
documentation for request module
sebpiq Jan 24, 2012
152c385
enhanced request how-to + example
sebpiq Jan 24, 2012
279fa0d
merge
sebpiq Jan 31, 2012
5f59d90
merged with trunk's master
sebpiq Feb 2, 2012
5bb6301
Response as a subclass of HttpResponse - first draft, not quite there…
sebpiq Feb 2, 2012
a0dc0b1
merge
sebpiq Feb 2, 2012
ca96b45
cleaned a bit Response/ResponseMixin code, added some documentation +…
sebpiq Feb 7, 2012
21292d3
cleaned Request/Response/mixins to have similar interface
sebpiq Feb 7, 2012
6963fd3
some docs for Request/Response/mixins
sebpiq Feb 7, 2012
2cdff1b
modified examples, somethin' still broken, can't find what
sebpiq Feb 7, 2012
db0b010
made suggested fixes
Feb 10, 2012
b33579a
attempt at fixing the examples
Feb 10, 2012
821844b
fixed examples, corrected small bugs in the process
sebpiq Feb 14, 2012
c04cb51
merged with trunk
sebpiq Feb 14, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion djangorestframework/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def authenticate(self, request):
Returns a :obj:`User` if the request session currently has a logged in user.
Otherwise returns :const:`None`.
"""
self.view.DATA # Make sure our generic parsing runs first
request.DATA # Make sure our generic parsing runs first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woop :)


if getattr(request, 'user', None) and request.user.is_active:
# Enforce CSRF validation for session based authentication.
Expand Down
Loading