ImageFields can return urls rather than file paths #1889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImageFields can show_urls=True instead of file names
|
ahhh dammit .. the whitespace comes from the github editor .. im fixing it :) |
fix whitespace bug ..
|
We need to consider:
|
|
I'll see what I can do about the remaining points over the weekend :-) My use case is that I store the images inside S3 so I have absolute URLs anyway. And that's why the relative stuff or the current file name is of no use for me. That's why I changed it in the first place. |
… methon on the object itself try to call the given serializer method on the serializer itself and on the model in that order
# By kakulukia # Via kakulukia * 'master' of github.com:kakulukia/django-rest-framework: allow to work like in django admin which also tries to call the given methon on the object itself Update fields.py Conflicts: rest_framework/fields.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageFields can show_urls=True instead of file names