Fix misleading AttributeError tracebacks on Request objects.
#2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
changed the title
AttributeError on Request` objects.AttributeError tracebacks on Request objects.
|
Thanks for working on this. I ended up tracing the problem to an issue with my auth backend, but it took some doing to get there because the original stack trace was lost. |
|
@foresmac Most welcome - needed to be done. |
|
Some unrelated stuff in this commit - mostly due to a silent upgrade of pep8 (we might consider pinning it) |
| @@ -154,7 +154,9 @@ def urlize_quoted_links(text, trim_url_limit=None, nofollow=True, autoescape=Tru | |||
|
|
|||
| If autoescape is True, the link text and URLs will get autoescaped. | |||
| """ | |||
| trim_url = lambda x, limit=trim_url_limit: limit is not None and (len(x) > limit and ('%s...' % x[:max(0, limit - 3)])) or x | |||
| def trim_url(x, limit=trim_url_limit): | |||
| return limit is not None and (len(x) > limit and ('%s...' % x[:max(0, limit - 3)])) or x | |||
There was a problem hiding this comment.
FWIW, I'd feel better if these conditional and y or x lines were replaced with explicit Python conditional assignment statements.
return ('%s...' % x[:max(0, limit - 3)]) if limit and len(x) > limit else xThere was a problem hiding this comment.
Yeah. We're just cloning from the Django codebase here so I don't particularly mind that it's a bit rubbish in this case.
tomchristie
added a commit
that referenced
this pull request
Feb 9, 2015
Fix misleading `AttributeError` tracebacks on `Request` objects.
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
This was referenced Oct 16, 2017
This was referenced Nov 6, 2017
This was referenced Nov 14, 2017
This was referenced Dec 10, 2017
This was referenced Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2108.