Skip to content

DateField to_representation can handle str and empty values. Fixes #2656, #2687. #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2015

Conversation

ryangallen
Copy link
Contributor

Let me know if these tests and fixes aren't appropriate.

@tomchristie tomchristie added the Bug label May 1, 2015
@tomchristie tomchristie added this to the 3.1.2 Release milestone May 1, 2015
tomchristie added a commit that referenced this pull request May 1, 2015
DateField to_representation can handle str and empty values. Fixes #2656, #2687.
@tomchristie tomchristie merged commit abcd6f2 into encode:master May 1, 2015
@tomchristie
Copy link
Member

Nice work!

@ryangallen ryangallen deleted the datefield branch May 3, 2015 17:25
@mdentremont
Copy link
Contributor

@tomchristie Do you know if a similar change should be made for the DateTimeField and the TimeField? I started looking into this but quickly ran into some trickyness with timezones in relation to strptime.

@tomchristie
Copy link
Member

@mdentremont Don't know. May be worth looking at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants