only include 'allow_blank' on supported fields #3012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,7 +102,7 @@ def get_field_kwargs(field_name, model_field): | |||
| if model_field.null and not isinstance(model_field, models.NullBooleanField): | |||
| kwargs['allow_null'] = True | |||
|
|
|||
| if model_field.blank: | |||
| if model_field.blank and isinstance(model_field, models.CharField): | |||
There was a problem hiding this comment.
I'd suggest having a look through the history for this line first.
Have we ever had different behavior in the past?
Are there any other built-in fields that don't subclass CharField but that do take an allow_blank argument?
jannon
changed the title
|
This feels like the right fix to me. |
tomchristie
added a commit
that referenced
this pull request
Jun 24, 2015
only include 'allow_blank' on supported fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I actually looked at fixing it for myself, it seemed like a pretty quick fix so I just went ahead and made a PR. The issue is described in #3011