Forms API #3475
Merged
Forms API #3475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good |
|
@tomchristie Did you want any review on this? Looks good. Needs tests. :-) |
|
Indeed tests and more comprehensive docs incoming. |
|
\o/ |
|
Docs updated. Still to do:
|
|
This looks great. |
Closed
|
Given that releasing 3.3.0 and launching the funding campaign is so important (Ie start getting resource onto the project against) I'm going to merge this in its current state. |
tomchristie
added a commit
that referenced
this pull request
Oct 22, 2015
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2138.
Closes #2060.