Update #3404 - adds deprecated function to track deprecations
#3478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: rest_framework/pagination.py tests/test_atomic_requests.py tests/test_permissions.py
|
👍🏽 |
|
@carltongibson sorry for the delay |
|
No worries. 😃 |
Merged
| ), | ||
| DeprecationWarning, | ||
| ) | ||
| deprecated((3, 0, 0), |
There was a problem hiding this comment.
The version against this looks wrong, no?
There was a problem hiding this comment.
looks like, will fix that one and the one under.
|
PR updated |
|
Do we really need some coverage or can we merge this ? |
|
LGTM although not sure we might want to take care of #3478 (comment) first. |
|
Are there currently any places where this should be used as part of the PR? |
|
@tomchristie Not sure it's a good thing to make it part of this PR. |
|
@xordoquy Possibly, but be helpful to enumerate 'em either way. |
|
On revisiting this, I'm not convinced we need this wrapper. Managing deprecations hasn't been a pain point for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over #3404. Fixes #3372