Update bootstrap version in browsable-api.md #3758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the update ! We'll try to be more careful about that if we upgrade the bootstrap theme. |
xordoquy
added a commit
that referenced
this pull request
Dec 19, 2015
Update bootstrap version in browsable-api.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was quite confused for a while because I was using Bootstrap v2.1.1 themes, which I assumed would work with the v2.1.1 that the Customizing section of the documentation claims django-rest-framework uses. However, this resulted in very odd visuals.
It wasn't until I searched github and found that the framework has apparently abandoned v2.1.1 for quite some time, and is apparently on v3.3.5 as of #3547, that I realized what was wrong.
So, this simple fix updates the version of Bootstrap mentioned in the docs.
Another alternative to this fix may be to simply mention that REST framework uses "bootstrap 3", in which case the docs are less likely to become inadvertently outdated.