Skip to content

Add 'default' value in OPTIONS #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rest_framework/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from django.utils.encoding import force_text

from rest_framework import exceptions, serializers
from rest_framework.fields import empty
from rest_framework.request import clone_request
from rest_framework.utils.field_mapping import ClassLookupDict

Expand Down Expand Up @@ -123,13 +124,16 @@ def get_field_info(self, field):

attrs = [
'read_only', 'label', 'help_text',
'min_length', 'max_length',
'min_length', 'max_length', 'default',
'min_value', 'max_value'
]

for attr in attrs:
value = getattr(field, attr, None)
if value is not None and value != '':
if value is not None and value != '' and value != empty:
if callable(value):
value.set_context(field)
value = value()
field_info[attr] = force_text(value, strings_only=True)

if getattr(field, 'child', None):
Expand Down
18 changes: 15 additions & 3 deletions tests/test_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,22 +69,26 @@ class ExampleSerializer(serializers.Serializer):
min_value=1, max_value=1000
)
char_field = serializers.CharField(
required=False, min_length=3, max_length=40
required=False, min_length=3, max_length=40, default='Cookie'
)
list_field = serializers.ListField(
child=serializers.ListField(
child=serializers.IntegerField()
)
)
nested_field = NestedField()
defaultuser_field = serializers.HiddenField(default=serializers.CurrentUserDefault())

class ExampleView(views.APIView):
"""Example view."""
def post(self, request):
pass

def get_serializer(self):
return ExampleSerializer()
if self.request:
return ExampleSerializer(context={'request': self.request})
else:
return ExampleSerializer()

view = ExampleView.as_view()
response = view(request=request)
Expand Down Expand Up @@ -128,7 +132,8 @@ def get_serializer(self):
'read_only': False,
'label': 'Char field',
'min_length': 3,
'max_length': 40
'max_length': 40,
'default': 'Cookie'
},
'list_field': {
'type': 'list',
Expand Down Expand Up @@ -165,6 +170,13 @@ def get_serializer(self):
'label': 'B'
}
}
},
'defaultuser_field': {
'type': 'field',
'required': False,
'read_only': False,
'label': 'Defaultuser field',
'default': 'AnonymousUser'
}
}
}
Expand Down