Fixed RelatedField(required=False) bug #3984
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I encountered the issue in totally unrelated (and invalid according to docs) case, but also found valid use case where it fails in exactly the same way.
When we want to fill-in the field specifically on
Model
level instead ofModelSerializer
we would make itrequired=False, allow_empty=True
and not pass the field at all indata
.Before this fix resolution of
Serializer.data
would yieldKeyError
.