Fix 1.10 deprecation warnings #4505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding comment from original PR: btw - there are two remaining deprecation warnings regarding the use of
Not sure how to fix these, and tbh I'm not too worried about it as it's internal to the test suite. |
rpkilby
commented
Sep 21, 2016
| @@ -124,22 +138,8 @@ def test_api_exception_rollback_transaction(self): | |||
| connection.features.uses_savepoints, | |||
| "'atomic' requires transactions and savepoints." | |||
| ) | |||
| @override_settings(ROOT_URLCONF='tests.test_atomic_requests') | |||
There was a problem hiding this comment.
btw, this test did not fail despite the urls property having been fully deprecated in 1.10
|
Now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to recreate #4488 - had to switch branches.
Description
Fixes a number of deprecation warnings generated by DRF. The to-many fix is the only one that really concerns me, as it makes a call to
model_meta.get_field_info. Not sure if there's a better way to pass that information to thecreate/updatemethods.There isn't really an easy way to test this without manually running the tests with the
-Werrorflag. That said, django-guardian also generates a number of warnings too. Just to test it out, you can install my fork, which has the fixes applied.