Skip to content

Ensure Location header is strictly a 'str', not subclass. #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

Ensure Location header is strictly a 'str', not subclass. #5544

merged 1 commit into from
Oct 30, 2017

Conversation

lovelydinosaur
Copy link
Contributor

Closes #5541

@lovelydinosaur lovelydinosaur added this to the 3.7.2 milestone Oct 30, 2017
@lovelydinosaur lovelydinosaur merged commit 2b6245d into master Oct 30, 2017
@lovelydinosaur lovelydinosaur deleted the strict-str-header branch October 30, 2017 13:08
canni
canni reviewed Oct 30, 2017
View reviewed changes
rest_framework/mixins.py
def get_success_headers(self, data):
try:
return {'Location': data[api_settings.URL_FIELD_NAME]}
return {'Location': str(data[api_settings.URL_FIELD_NAME])}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not six.text_type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@canni canni canni left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.7.2 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@lovelydinosaur @canni