Upgrade to bootstrap 3.4.0 to fix XSS vulnerability #6368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carltongibson fyi. Let me know if there are any additional actions. |
|
No diff to the CSS? |
|
@carltongibson Completely forgot about the CSS. They should be added now. |
|
Resolving this in #6405, so that I can ensure I've downloaded the minified JS myself, since it's otherwise unreviewable. Thanks for progressing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picking up Bootstrap
3.4.0to fix an XSS vulnerability found in3.3.7refs #6178