Fix requestBody not wrapped in a schema in OpenAPI #6565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @Lucidiot. Thanks for this.
Does the exact same not apply to responses too? (Will check now...)
Assuming so, can you add? (If not, say, I can do it!)
|
It seems so and I added it :) |
|
Super. Thanks. |
carltongibson
approved these changes
Apr 4, 2019
carltongibson
pushed a commit
that referenced
this pull request
Apr 29, 2019
* Wrap requestBody contents in JSON schemas * Update unit test * Wrap response schemas in a schema object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6562, on the OpenAPI generation PR #6532 by @carltongibson: wraps schemas in the
requestBodyproperty on an operation in aschemakey.