Dict field allow empty #6583
Merged
Dict field allow empty #6583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
suggested changes
May 9, 2019
tests/test_fields.py
Outdated
| output = field.run_validation(None) | ||
| assert output is None | ||
|
|
||
| def test_allow_empty(self): |
There was a problem hiding this comment.
I would change the name to test_allow_empty_disallowed (or similar), as test_allow_empty implies allow_empty=True.
There was a problem hiding this comment.
Ok, renamed
| "Project-Id-Version: PACKAGE VERSION\n" | ||
| "Report-Msgid-Bugs-To: \n" | ||
| "POT-Creation-Date: 2016-07-12 16:13+0100\n" | ||
| "POT-Creation-Date: 2019-04-11 23:21+0200\n" |
There was a problem hiding this comment.
Translations are managed with transifex and are updated via the release process. These changes should be removed.
There was a problem hiding this comment.
Ok, changes in this file have been dropped
|
Thank you for your review, I've applied the changes requested and rebased onto master. |
|
Looks spot on to me. |
terencehonles
pushed a commit
to terencehonles/django-rest-framework
that referenced
this pull request
Oct 8, 2020
* dict field: support allow_empty option * document ListField allow_empty option * document HStoreField allow_empty parameter
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* dict field: support allow_empty option * document ListField allow_empty option * document HStoreField allow_empty parameter
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
* dict field: support allow_empty option * document ListField allow_empty option * document HStoreField allow_empty parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds support for
allow_emptyoption toDictFieldandHStoreField.Enforcing that the field value is not empty is a common use case in my opinion.
The same parameter was already supported by the other composite field
ListField.Param defaults to
Falseso current behaviour is not changed.