Skip to content

Update docs search plugin #6810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Update docs search plugin #6810

merged 1 commit into from
Jul 16, 2019

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Jul 16, 2019

Fixes #6807. Plugin scripts are defer loaded in the base template instead of from the theme script.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Didn't actually test it... 😬 — assuming you did? :)

@rpkilby
Copy link
Member Author

rpkilby commented Jul 16, 2019

I did, but it would be good if someone else could double check.

@carltongibson
Copy link
Collaborator

Grrr. Thought you'd say that... 🙂

Screenshot 2019-07-16 at 21 09 08

... OK yes, seems to be working at 5c12723

@carltongibson
Copy link
Collaborator

@tomchristie A docs rebuild with this and #6811 would be good.

@rpkilby rpkilby merged commit 0cb2523 into encode:master Jul 16, 2019
@rpkilby rpkilby deleted the fix-docs-search branch July 16, 2019 20:00
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search doesn't work in the documentation, require.js not found
2 participants