OpenAPI endpoint enumeration refactoring. #7127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
commented
Jan 8, 2020
| for path, method, view in view_endpoints: | ||
| if not self.has_view_permissions(path, method, view): | ||
| continue | ||
|
|
There was a problem hiding this comment.
Here I intend for per path, method, view component generation, components (if any) then becoming parameters to get_operation()
|
@tfranzel-cashlink @gnuletik. Thanks both for your PRs in #7096 and #7124. I've made some adjustments here to allow the access point I think we need, without needing to pass schema-level info down into the individual view inspector. I imagine now an I'll work on this going forward but if you see where I'm going with it and are inspired to jump-in, please do. |
gnuletik
added a commit
to gnuletik/django-rest-framework
that referenced
this pull request
Jan 12, 2020
This was referenced Jan 21, 2020
gnuletik
added a commit
to gnuletik/django-rest-framework
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just _inline method_s
get_path()which wasn't really needed. It's preparatory to add reference component generation parallel to the current path operation generation.It includes the commits from #7125 and #7126. So can be Rebase & Merged to close all three.
(They're intended as three commits for the history.)