Fix pk-only optimization for properties #7142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kevin-brown
approved these changes
Apr 3, 2020
auvipy
approved these changes
Apr 8, 2020
6 tasks
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
* Add callable/prop tests for pk-only optimization * Fix related field pk-only optimization for props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the related field pk-only optimization check to also handle properties. Should fix #6643 as well as #4653. Tests were adapted from #2690, but didn't include the hyperlink tests, since I don't think they're necessary here.
In regards to #2690 (comment), I'm not too worried about the tests model changes, since the rest of the test module fairly heavily relies on them. I'm not worried about impact either, since the method/prop won't have an impact on other model serializer tests. Thoughts?