Add type for choicefield #7161
Merged
Add type for choicefield #7161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-brown
previously requested changes
Jan 27, 2020
kevin-brown
reviewed
Jan 27, 2020
|
@carltongibson Waiting for your valuable review. |
|
Hi @dhaval-mehta. Please don´t do that. I know. (And thanks for your effort!) |
carltongibson
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Yep, OK. This looks good @dhaval-mehta. Welcome aboard! ⛵️
Thanks for the reviews @kevin-brown 🥇
|
@carltongibson @kevin-brown This is my first open-source contribution. Thanks for your guidance. |
6 tasks
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carltongibson @kevin-brown As we have discussed in #7080, In majority cases, the
typeof enum values for the choicefield will be one of the following.In this merge request, I have added code to generate the
typefor majority cases.