Revert "Fix api_view decorator with Django 4" #8297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c97946.
|
Okay, it would be better that we have something with the schema generation be not-quite-right with Django 4.0, than it is for us to break existing codebases (on Django 3.2 or lower, see #8294) We can consider #8294 again, but I'd like a clearer understand of exactly what it fixes, so that we can attempt to make the same fix but with a more minimal footprint. All of that code is arcane dark magic, and I don't trust any of it. Let's tread more carefully this time. |
Closed
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
…)" (encode#8297) This reverts commit 9c97946.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8291