Skip to content

Conversation

Q-back
Copy link
Contributor

@Q-back Q-back commented Apr 29, 2022

fix: Documentation did not point out that the default value of required
Field parameter is False depending on Django's Model.field.

This is a continuation of #7222.

The rationale of my PR is this part of the code:

if model_field.has_default() or model_field.blank or model_field.null:

fix: Documentation did not point out that default value of `required`
`Field` parameter is `False` depending on the Django's `Model.field`.
@Q-back Q-back force-pushed the q-back/update-fields-required-docs branch from d745d2d to 5f5f097 Compare April 29, 2022 16:03
@lovelydinosaur
Copy link
Contributor

Yup seems reasonable.

@lovelydinosaur lovelydinosaur merged commit cdc956a into encode:master May 3, 2022
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
fix: Documentation did not point out that default value of `required`
`Field` parameter is `False` depending on the Django's `Model.field`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants