use warnings rather than logging a warning for DecimalField warnings #9367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Apr 27, 2024
Merged
merwok
reviewed
Nov 20, 2024
| warnings.warn("max_value should be a Decimal instance.") | ||
| if self.min_value is not None and not isinstance(self.min_value, decimal.Decimal): | ||
| logger.warning("min_value in DecimalField should be Decimal type.") | ||
| warnings.warn("min_value should be a Decimal instance.") |
There was a problem hiding this comment.
Could you add a stacklevel param so that python displays a trace with the faulty calling code rather than this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addressing #8972 (comment)