Skip to content

Add & Fixing missing translations for ko_KR #9571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Apr 2, 2025
Merged

Add & Fixing missing translations for ko_KR #9571

merged 34 commits into from
Apr 2, 2025

Conversation

TGoddessana
Copy link
Contributor

Description

  1. updated the missing translation files.
  2. Fixed incorrect translations.
  3. made the wording of all warnings and prompts consistent with Django's Korean translation. For example, Django uses “~~세요” rather than “~~시오” in its prompts. Also, Django translates the word “User” as “사용자” rather than “유저(as pronounced)”.

@TGoddessana
update django.po file
57c3713
@TGoddessana
update django.po translators
bf51b6b
@TGoddessana
Changed the translation for the word “User” from “유저” to “사용자” to mak…
319d51b 
…e it consistent with Django's translation

reference: https://github.com/django/django/blob/5a91ad3d7115c692d497663a155edee5ebc8989c/django/contrib/admin/locale/ko/LC_MESSAGES/django.po#L601
@TGoddessana
Add missing translation for the word “Token"
548a540
@TGoddessana
Fix wrong translation for word "Created"
86716e6
@TGoddessana
Fix translation for "Tokens", just like django translation.
4dbfe56 
reference: https://github.com/django/django/blob/5a91ad3d7115c692d497663a155edee5ebc8989c/django/contrib/auth/locale/ko/LC_MESSAGES/django.po#L235
@TGoddessana
Add missing translation for "Invalid Input"
fab9087
@TGoddessana
Add missing translation for throttling messages
f57e273
@TGoddessana
Add missing translation for CharField, BooleanField messages
ce4c58b
@TGoddessana
fix: remove unnecessary space
cdd6519
@TGoddessana
Feat: add missing translation for SlugField error message
73d0247
@TGoddessana
Feat: add missing translation for UUIDField error message
171cb87
@TGoddessana
Fix: add (boolean) for booleanField message
ac7bee8
@TGoddessana
Feat: add missing translation for integer to float error message
0d6a00c
@TGoddessana
Feat: add & fix translation for DecimalField
70ffca4
@TGoddessana
Feat: add & fix translation for DateTimeField
e0842b7
@TGoddessana
Feat: add & fix translation for DurationField
2454966
@TGoddessana
Feat: add & fix translation for Selection&FilePathField
54b5377
@TGoddessana
Feat: add & fix translation for DictField
a01c824
@TGoddessana
Feat: add missing translation for filters
73f196e
@TGoddessana
Feat: add missing translations for template
d720799
@TGoddessana
Feat: Change end punctuation to the “~세요.” used by Django translations
ff5d35b
@TGoddessana
update django.po translators
31d2f9b
@TGoddessana TGoddessana mentioned this pull request Oct 22, 2024
Closed
TGoddessana
TGoddessana commented Oct 22, 2024
View reviewed changes
rest_framework/locale/ko_KR/LC_MESSAGES/django.po
"POT-Creation-Date: 2024-10-22 16:13+0900\n"
"PO-Revision-Date: 2020-10-13 19:45+0000\n"
"Last-Translator: Xavier Ordoquy <xordoquy@linovia.com>\n"
"Language-Team: Korean (Korea) (http://www.transifex.com/django-rest-framework-1/django-rest-framework/language/ko_KR/)\n"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we decided to handle translations in Github(#9535), i deleted the transifex line.

@TGoddessana TGoddessana changed the title Add & Fixing missing translation for ko_KR Add & Fixing missing translations for ko_KR Oct 23, 2024
overtae
overtae suggested changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@overtae overtae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

띄어쓰기가 누락된 것 같습니다.

browniebroke
browniebroke reviewed Mar 31, 2025
View reviewed changes
@TGoddessana TGoddessana requested a review from browniebroke April 2, 2025 16:17
@browniebroke browniebroke merged commit 9b1e8d2 into encode:master Apr 2, 2025
7 checks passed
@browniebroke
Copy link
Collaborator

Thanks 🎉

@browniebroke browniebroke added this to the 3.16 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@browniebroke browniebroke browniebroke approved these changes

+1 more reviewer

@overtae overtae overtae requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Translations
Projects
None yet
Milestone
3.16
Development

Successfully merging this pull request may close these issues.
3 participants
@TGoddessana @browniebroke @overtae