Remove Python 3.9 from workflow matrix #9781
Conversation
|
We should probably also update all the package metadata and docs? |
|
yes, thats why it is draft for now. |
peterthomassen
force-pushed
the
patch-1
branch
from
3f37297 to
3003fa4
Compare
| - name: Run extra tox targets | ||
| if: ${{ matrix.python-version == '3.9' }} | ||
| run: | | ||
| tox -e base,dist,docs |
There was a problem hiding this comment.
What are these extra tests for? Can they really be removed when dropping 3.9 support?
There was a problem hiding this comment.
Good catch, I'd like to keep running them on our oldest supported version (3.10)
There was a problem hiding this comment.
I think we should just use python 3.12 or 3.13 to run the extra targets, instead of 3.9.
| - name: Run extra tox targets | ||
| if: ${{ matrix.python-version == '3.9' }} | ||
| run: | | ||
| tox -e base,dist,docs |
There was a problem hiding this comment.
Good catch, I'd like to keep running them on our oldest supported version (3.10)
|
I'm not familiar in what way these extra targets are special so that they should only run with the oldest support version. Why is that? |
Hum... I'm actually not sure it matters. I said that because that seemed like how they were setup and it's probably where we're most likely to break something, but it's just a gut feeling. A theorical example that comes to mind would be removal of an optional dependency because it's now part of the std lib (pytz/zoneinfo). We could have some tests break on older Python versions where ZoneInfo wouldn't be supported if we forgot about it... The base job might have caught such issue: running on the older Python without the optional dep. Lines 28 to 32 in 0f57622 Seems like the dist job treats some warnings as errors: Lines 34 to 39 in 0f57622 So maybe this one should actually run on the most recent Python? |
EOL in october....