Skip to content

Block: Set bottom_snap_path when ready #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Block: Set bottom_snap_path when ready #175

merged 1 commit into from
Jul 30, 2024

Conversation

manuq
Copy link
Contributor

@manuq manuq commented Jul 30, 2024

The bottom_snap must be set on ready, regardless of previously setting it.

Regression from 9aae2bb

Fixes: #172

The bottom_snap must be set on ready, regardless of previously setting
it.

Regression from 9aae2bb

Fixes: #172
@manuq manuq requested review from dbnicholson and wnbaum July 30, 2024 11:38
Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm still getting confused on when variables are set by Godot. I suppose that what's happening is that the node hasn't been added to the scene yet, so the initial get_node_or_null returns null.

@dbnicholson dbnicholson merged commit d008f06 into main Jul 30, 2024
2 checks passed
@dbnicholson dbnicholson deleted the fix-bottom-snap branch July 30, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong code generation with two print blocks
2 participants